fix: wrong parsing of recipe yield input#1944
Merged
christianlupus merged 4 commits intonextcloud:masterfrom Dec 7, 2023
j0hannesr0th:master
Merged
fix: wrong parsing of recipe yield input#1944christianlupus merged 4 commits intonextcloud:masterfrom j0hannesr0th:master
christianlupus merged 4 commits intonextcloud:masterfrom
j0hannesr0th:master
Conversation
Collaborator
christianlupus
left a comment
christianlupus
left a comment
There was a problem hiding this comment.
Is it not simpler, to solve the root of the problem? In line 83 the model is synced with the content of an input field. This causes the trouble of different data types. Normally, it is integer, but it is set to string internally after changes.
If you just added .number.trim (to v-model), the value is converted to a number before storing.
Signed-off-by: Johannes Roth <git@jrcloud.de>
Signed-off-by: Johannes Roth <git@jrcloud.de>
Signed-off-by: Johannes Roth <git@jrcloud.de>
Contributor
Author
|
I've updated the code and removed the browser native increase and decrease buttons. |
christianlupus
approved these changes
Dec 7, 2023
Signed-off-by: Christian Wolf <github@christianwolf.email>
Collaborator
|
/cb-backport main-0.10.x |
christianlupus
pushed a commit
that referenced
this pull request
Dec 10, 2023
fix: wrong parsing of recipe yield input Signed-off-by: Johannes Roth <git@jrcloud.de> fix: wrong parsing of recipe yield input Signed-off-by: Johannes Roth <git@jrcloud.de> Make stylelint and prettier happy Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
added a commit
that referenced
this pull request
Dec 10, 2023
…e-yields Backport of #1944: fix entry recipe yields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topic and Scope
Fixes #1937
Aufzeichnung.2023-12-06.192544.mp4
Concerns/issues
none.
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.